Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#48717] Replace DelayedJob with GoodJob. #12998

Merged
merged 25 commits into from
Mar 6, 2024
Merged

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    fd6a899 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f82090d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    6b8e1dc View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    bddc471 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1ce114 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    8c86d12 View commit details
    Browse the repository at this point in the history
  2. Resurrect removed migrations.

    ba1ash committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e6dcb82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e615525 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f17ad24 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    8ab39f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    227029c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dab95b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. React on comments from review.

    - Do not use string literals for job class names. Use `class.name` instead.
    - Rename `ApplicationJob#good_job_scheduled_at` to `ApplicationJob#job_scheduled_at` to be backend agnostic.
    - update queries in bin/check-worker-liveness to use good_jobs table
    - Set good_job config options through appropriate OpenProject::Configuration
    - Remove delayed_jobs table.
    - Update health_check docs.
    ba1ash committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2267a0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e054adb View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Make execute_sql work.

    ba1ash committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f2ffac9 View commit details
    Browse the repository at this point in the history
  2. Fix #upsert_status race condition.

    Rescue ActiveRecord::RecordNotUnique and then retry.
    ba1ash committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f296c54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d32d332 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8eb5674 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    a59e01e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0294e4b View commit details
    Browse the repository at this point in the history
  3. Use execute over execute_sql.

    Due to no need in sanitization.
    ba1ash committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    fa67e04 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    ee88c89 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Migrate 'in queue' jobs to good_jobs table.

    Update good_job version as well.
    ba1ash committed Mar 5, 2024
    2 Configuration menu
    Copy the full SHA
    c69d5eb View commit details
    Browse the repository at this point in the history
  2. Remove delayed_job dependecy. Lock jobs.

    - Remove delayed_job dependecy completely from Gemfile.
    - Lock jobs during migration from delayed_jobs to good_jobs using SELECT FOR UPDATE.
      It means that potentially not shut down DJ worker will not be able to
      pick them up for performing during the migration process. After
      migration has been finished the jobs in question will be in
      good_jobs table and delayed_jobs table will be removed. So,
      duplicate execution should not happen.
    ba1ash committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dbab61a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    ccb275b View commit details
    Browse the repository at this point in the history