[#50264] Allow Edit/Comment shared with users to be mentionable #14214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
approved these changes
Nov 23, 2023
oliverguenther
deleted the
implementation/50264-allow-shared-users-to-be-mentioned
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users with the Edit or Comment Work package role to be mentionable in the work packages they've been shared with, alongside existing project members that were mentionable.
There's a caveat with the principals api when signaling where uniqueness is not really handled since the JSON response is directly built in SQL. There's already a discussion planned for it with Jens to solve this. In the meantime, de-duplication of the returned Principals takes place on the client side, specifically in the CKEditor build. Here's a linked PR for it opf/commonmark-ckeditor-build#86
Notes
See: https://community.openproject.org/work_packages/50264