[#41299] Updated API spec for placeholder users #14769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://community.openproject.org/wp/41299 - added inheritance hirarchy for principal resource models - added placeholder user paths - revisited other principal specifications
- also fixed some older rubocop issues
Kharonus
force-pushed
the
bug/41299-placeholderuser-resource-not-described-in-the-api-spec
branch
from
92775e2
to
d3edd15
Compare
- changed HTTP code back to 202 (deletion in progress) - pin type enum - amend representer rendering spec
it is not possible to add placeholder users to a group via API or UI. The filters are probably superfluous, but I didn't remove them in this PR.
I added the status property to the model of placeholder users in the the API response. |
Kharonus
deleted the
bug/41299-placeholderuser-resource-not-described-in-the-api-spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41299
WAT??
Thoughts and stuff
Hey guys, the PR is rather big, with a lot of text. The reason for that is, that placeholder users were not documented at all, yet. And also affect the documentation about users and groups.
I hope, the changes are understandable, yet, there are some open questions: