Bug/54109 mobile scrolling within a modal scrolls the content underneath #15687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
from
442e0f9
to
aa0e172
Compare
HDinger
requested changes
May 29, 2024
There was a problem hiding this comment.
On most of our pages, the body is not the actual scroll container. The solution does correctly prevent any scrolling in the back. However, the scroll position is not maintained correctly because you are storing the value from the body and not from the actual scroll container.
Unfortunately, we do not have that one container that is responsible for scrolling on all pages. It even differs between mobile and and desktop size. So I am not sure whether we can follow this approach after all. If you want to, we can discuss that today.
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
2 times, most recently
from
0dd22bf
to
def9e8d
Compare
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
from
def9e8d
to
9790542
Compare
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
2 times, most recently
from
ddba9aa
to
4efb378
Compare
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
2 times, most recently
from
99192f6
to
95e9e70
Compare
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
from
95e9e70
to
2ccf51c
Compare
apfohl
force-pushed
the
bug/54109-mobile-scrolling-within-a-modal-scrolls-the-content-underneath
branch
from
70cb5e0
to
fa70157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/54109
This fixes the scrolling background when a modal is open. This is achieved by adding and removing an attribute to the body respecting when a modal is open or not.