Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/40437 emoji reactions to work package comments #16020

Draft
wants to merge 40 commits into
base: dev
Choose a base branch
from

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    aed51f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    53aa61c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into epic/4…

    …0437-easy-emoji-reactions,-eg-thumbs-up-on-activity-entries
    jjabari-op committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2b27488 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e73506 View commit details
    Browse the repository at this point in the history
  3. avoid n+1 queries

    jjabari-op committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7da1bf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    3c9da77 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dbae3ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81d62c3 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ee29224 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    19f3669 View commit details
    Browse the repository at this point in the history
  2. fixed comment rendering

    jjabari-op committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    71966de View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6f0dc4a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    560d7f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e86f322 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    86d5656 View commit details
    Browse the repository at this point in the history
  2. rubocop auto-amendments

    akabiru committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    338174f View commit details
    Browse the repository at this point in the history
  3. applied invisible style to reactions where the current user itself ha…

    …s not reacted as requested by @psatyal
    jjabari-op committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0f17cee View commit details
    Browse the repository at this point in the history
  4. Merge branch 'feature/54733-primerise-the-activity-panel' into featur…

    …e/40437-emoji-reactions-to-work-package-comments
    jjabari-op authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    acc920a View commit details
    Browse the repository at this point in the history
  5. fixed merge

    jjabari-op committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    14108bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6ef94ef View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. feat[Op#40437]: Introduce view only reactions covered by feature specs

    Users who do not have commenting permissions: typically the `add_work_package_notes` and anonymous
    users cannot add new reactions but they can view any existing reactions. Futher, the "Add reactions" button
    is also hidden from them.
    
    In view only state, the emoji reactions render as primer invisible buttons in disabled state.
    
    > They can respond to user input and provide feedback, but it does not trigger any actions.
    > See: https://primer.style/components/button#inactive
    
    The view only reactions mimic primer inactive buttons but without the muted styling and cursor change
    akabiru committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a3d0747 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    31e75b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    9751869 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6094509 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7392afa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f777c52 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c09cffc View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    371f2f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    c7b5e9e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. chore[Op#40437]: store emoji in uncode format backed by string enum

    UTF-8 is widely adopted and the default format for Postgres; storing emoji's in unicode format is then possible
    and should be searchable as any other string- and leveragable via AR named enums.
    
    Whilst we could also store integer numbered enums, it would introduce additional overhead that seems unnecessary
    akabiru committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    994be68 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. feat[Op#58250]: Store reactions as indexed enums later mapped to unicode

    Avoid possible collation issues in uncode formats- storing reactions allows us to read the emojis from relevant stores at runtime
    akabiru committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b29c277 View commit details
    Browse the repository at this point in the history
  2. fix[Op#40437]: Update reactions text

     * ARIA-label, show names and emoji type: "{Name of reaction} by {user A}, {user B} and {user C}".
     * Visually, show just names: "{user A}, {user B} and {user C}"
    akabiru committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5f57d6f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b632c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. feat[Op#40437]: Introduce single emoji reactions aggregation query to…

    … avoid n+1 calls on journals
    akabiru committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9f08b83 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. feat[Op#40437]: define emoji reactions aggregation in index component

    Pass it down the component chain. TODO: reduce allocation bloat by extracting it to a lazy memoized helper
    akabiru committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    29f0155 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3856149 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65c2aa2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a0b25f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    340895a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b08ed5b View commit details
    Browse the repository at this point in the history