Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#58144] Show email on the UI for users with permission #16919

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from
Draft

[#58144] Show email on the UI for users with permission #16919

wants to merge 26 commits into from

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Oct 8, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/58144

What are you trying to accomplish?

Remove hide_mail flag and replace with :view_user_email permission checks.
Display email addresses in the user autocompleters.

ToDo

  • Remove user hide_mail setting.
  • Replace existing user email preferences with a view_user_email permission check.
  • Update autocompleters to display emails based on the view_user_email permission check.
    • Select project members
    • Share work packages
    • Work Package assignee, accountable, watchers
    • Work Package filter user autocompleters
    • Share project lists
    • Select group members
    • Invite user modal (+ button on the top bar)

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Base automatically changed from implementation/58143-add-the-new-role-and-apply-defaults to dev October 11, 2024 10:02
@dombesz dombesz force-pushed the implementation/58144-show-email-on-the-ui-for-users-with-permission branch from 6a3f436 to 8e09dfc Compare October 11, 2024 10:14
EinLama
EinLama reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently looking into this PR to understand what it does. Just leaving some comments here as note to myself :)

spec/services/users/set_attributes_service_integration_spec.rb Show resolved Hide resolved
spec/requests/api/v3/principals/principals_resource_spec.rb Outdated Show resolved Hide resolved
dombesz and others added 16 commits October 22, 2024 09:53
@dombesz @EinLama
[#58144] Show email on the UI for users with permission
e453fcc 
https://community.openproject.org/work_packages/58144
Remove hide_mail flag and replace with :view_user_email permission checks
@dombesz @EinLama
Add migration spec
85cfefe
@dombesz @EinLama
Fix specs
5cfe28a
@dombesz @EinLama
Remove hideMail flag from the frontend and documentation
4f759ea
@dombesz @EinLama
Fix specs
3a81b7c
@dombesz @EinLama
Do not allow searching for email without view email permission
cf810d2
@dombesz @EinLama
Fix specs
ad0b57c
@dombesz @EinLama
Enable email signaling and display emails in user autocompleters.
f208254
@HDinger @EinLama
Do not truncate the whole user option completely but rather the part …
8e2263d 
…that is not visible any more (e.g. inside the WP table)
@dombesz @EinLama
Simplify the autocompleter layout, plus fix truncation issue on small…
fcde3cd 
… desktop size.
@dombesz @EinLama
Apply autocompleter emails to the invite user modal.
e86ae7b
@dombesz @EinLama
Add email to user related autocomplete filters
f1c63d5
@dombesz @EinLama
Make the autocompleter aligned on the team planner and the assignee b…
849b575 
…oard
@dombesz @EinLama
Fix specs
e0472a1
@dombesz @EinLama
Add user invitation, work package share, user signal rendering specs
f4d1be0
@EinLama
Changes from dev
cb1330c
@EinLama EinLama force-pushed the implementation/58144-show-email-on-the-ui-for-users-with-permission branch from f9d158f to cb1330c Compare October 22, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinLama EinLama EinLama left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dombesz @EinLama @HDinger