Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#57816] create hierarchy items #16930

Merged
merged 12 commits into from
Oct 15, 2024
Merged

Conversation

Kharonus
Copy link
Member

Ticket

OP#57816

  • added form for item creation
  • added borderbox in items component

What are you trying to accomplish?

  • enable creation of hierarchy items on top most level

What approach did you choose and why?

  • enable turbo stream updates to render inline form to create items
  • add form validation
  • render existing items in borderbox

- https://community.openproject.org/work_packages/57816
- added form for item creation
- added borderbox in items component
- render hierarchical item in component
- add missing routes
- localize dry-validation error
- removing ineffective system arguments
- add i18n support for validation messages
@Kharonus Kharonus self-assigned this Oct 10, 2024
@Kharonus Kharonus changed the title Implementation/57816 enable item creation [#57816] create hierarchy items Oct 10, 2024
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Kharonus Kharonus force-pushed the implementation/57816-enable-item-creation branch from c0c901f to 561e2a5 Compare October 11, 2024 11:10
cbliard and others added 2 commits October 14, 2024 08:37
The `LocaleExtractor` recognizes these kind of files:

  - `<locale>.yaml`
  - `<locale>_something.yaml`

It does not recognize these files we use:

  - `js-<locale>.yaml` (locale is extracted as `js-<locale>`)
  - `<locale>.seeders.yaml` (locale is extracted as `<locale>.seeders`)

It's fixed by deleting the `js-` prefix and the `.seeders` suffix from
the extracted locale.
@Kharonus Kharonus merged commit 6c5c347 into dev Oct 15, 2024
11 checks passed
@Kharonus Kharonus deleted the implementation/57816-enable-item-creation branch October 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants