-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#57816] create hierarchy items #16930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://community.openproject.org/work_packages/57816 - added form for item creation - added borderbox in items component
- render hierarchical item in component - add missing routes - localize dry-validation error
- removing ineffective system arguments - add i18n support for validation messages
Kharonus
changed the title
Implementation/57816 enable item creation
[#57816] create hierarchy items
Oct 10, 2024
apfohl
approved these changes
Oct 11, 2024
akabiru
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Kharonus
force-pushed
the
implementation/57816-enable-item-creation
branch
from
October 11, 2024 11:10
c0c901f
to
561e2a5
Compare
cbliard
reviewed
Oct 14, 2024
The `LocaleExtractor` recognizes these kind of files: - `<locale>.yaml` - `<locale>_something.yaml` It does not recognize these files we use: - `js-<locale>.yaml` (locale is extracted as `js-<locale>`) - `<locale>.seeders.yaml` (locale is extracted as `<locale>.seeders`) It's fixed by deleting the `js-` prefix and the `.seeders` suffix from the extracted locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#57816
What are you trying to accomplish?
What approach did you choose and why?