-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OIDC configuration UI #16935
Merged
Merged
Update OIDC configuration UI #16935
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
e0c5dd3
Update OIDC configuration UI.
ba1ash 2e22ab2
Remove has_actions
oliverguenther db82830
Extend form validation
oliverguenther ef21f6e
Extract metadata_url getter
oliverguenther e857bcd
Add mapping
oliverguenther 19eab3b
Same button layout as saml
oliverguenther 77b8da4
Don't walk through sections without edit_mode
oliverguenther a1dd527
Hash builder with mapping
oliverguenther 4e897fb
Allow custom icon
oliverguenther 980dd1c
Move migration to engine
oliverguenther 3b4ccfd
Format migration text
oliverguenther 533312b
Configuration mapper
oliverguenther 30fae2b
Rename seeder
oliverguenther 7247a23
Remove form_post security impact option
oliverguenther a72c0cb
Allow seeding with path config as shown in docs
oliverguenther 15490f2
Reintroduce sections, add one for mapping
oliverguenther 7ecd5df
Fix inflection
oliverguenther 7c873eb
Extend spec to use absolute URL
oliverguenther 6fe5456
Feature spec
oliverguenther 7b8bbee
Contract specs
oliverguenther fc4908c
Config mapper spec
oliverguenther 2f3e7da
Service specs
oliverguenther 524a459
Add claims
oliverguenther dcc293c
Remove metadata_url from discoverable attribute check
oliverguenther 3312cc9
Allow path based attributes after all
oliverguenther 718d934
Fix generation of provider classes from new config
oliverguenther d0390a2
Skip metadata check for built-in
oliverguenther 46eb11a
Remove unused providers helper
oliverguenther d5987fa
Remove state lambda
oliverguenther 0959dca
Set default issuer
oliverguenther 15dcc76
Allow setting omniauth direct login provider to the new auth providers
oliverguenther 7989cdb
Show delete warning for deleting SSO providers (#16981)
oliverguenther 5bb581a
Parse tenant from previous config
oliverguenther 343063a
Parse limit_self_registration
oliverguenther e9ef120
Also map host
oliverguenther 32d4da1
Fix and add test for self-registration
oliverguenther 65fb080
Re-enable custom attribute mapping spec
oliverguenther 0d15a67
Add post_logout_redirect_uri
oliverguenther 32afae1
Allow admin mapping
oliverguenther 98e9d57
Add migration spec
oliverguenther 6ac6af4
Better option mapping
oliverguenther File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
modules/auth_saml/app/views/saml/providers/confirm_destroy.html.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<%#-- copyright | ||
OpenProject is an open source project management software. | ||
Copyright (C) the OpenProject GmbH | ||
|
||
This program is free software; you can redistribute it and/or | ||
modify it under the terms of the GNU General Public License version 3. | ||
|
||
OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: | ||
Copyright (C) 2006-2013 Jean-Philippe Lang | ||
Copyright (C) 2010-2013 the ChiliProject Team | ||
|
||
This program is free software; you can redistribute it and/or | ||
modify it under the terms of the GNU General Public License | ||
as published by the Free Software Foundation; either version 2 | ||
of the License, or (at your option) any later version. | ||
|
||
This program is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU General Public License for more details. | ||
|
||
You should have received a copy of the GNU General Public License | ||
along with this program; if not, write to the Free Software | ||
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
|
||
See COPYRIGHT and LICENSE files for more details. | ||
|
||
++#%> | ||
<%= styled_form_tag(saml_provider_path(@provider), | ||
class: 'danger-zone', | ||
method: :delete) do %> | ||
<section class="form--section"> | ||
<h3 class="form--section-title"> | ||
<%= t('saml.delete_title') %> | ||
</h3> | ||
<p> | ||
<%= t('provider.delete_warning.provider', name: content_tag(:strong, @provider.display_name)).html_safe %> | ||
</p> | ||
<ul class="mb-3"> | ||
<li> <%= t('provider.delete_warning.delete_result_1') %> | ||
<li> <%= t('provider.delete_warning.delete_result_user_count', count: @provider.user_count) %> | ||
<% if Setting.omniauth_direct_login_provider == @provider.slug %> | ||
<li> <%= t('provider.delete_warning.delete_result_direct') %> | ||
<% end %> | ||
</ul> | ||
<p class="danger-zone--warning"> | ||
<span class="icon icon-error"></span> | ||
<span><%= t('provider.delete_warning.irreversible_notice') %></span> | ||
</p> | ||
<p> | ||
<%= t('provider.delete_warning.input_delete_confirmation', name: "<em class=\"danger-zone--expected-value\">#{h(@provider.display_name)}</em>").html_safe %> | ||
</p> | ||
<div class="danger-zone--verification"> | ||
<%= text_field_tag :delete_confirmation %> | ||
<%= styled_button_tag title: t(:button_delete), class: '-primary', disabled: true do | ||
concat content_tag :i, '', class: 'button--icon icon-delete' | ||
concat content_tag :span, t(:button_delete), class: 'button--text' | ||
end %> | ||
<%= link_to saml_providers_path, | ||
title: t(:button_cancel), | ||
class: 'button -with-icon icon-cancel' do %> | ||
<%= t(:button_cancel) %> | ||
<% end %> | ||
</div> | ||
</section> | ||
<% end %> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 6 lines should really go into a helper and not live in a template.