[58467] Changed add hierarchical item behavior #17027
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this cause a double send of the turbo-frame? |
Why? It only adds the form to the response. |
|
@mereghost Ah, now I see what you mean lol. |
apfohl
force-pushed
the
bug/58467-item-add-form-disappears-after-added-a-new-item-to-a-custom-field-of-type-hierarchy
branch
from
94332ab
to
b581a56
Compare
When adding a new item in the hierarchy the item form will stay open for the next entry.
apfohl
force-pushed
the
bug/58467-item-add-form-disappears-after-added-a-new-item-to-a-custom-field-of-type-hierarchy
branch
from
b581a56
to
0f5114c
Compare
mereghost
approved these changes
Oct 24, 2024
apfohl
deleted the
bug/58467-item-add-form-disappears-after-added-a-new-item-to-a-custom-field-of-type-hierarchy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/document-workflows-stream/work_packages/58467/github
What are you trying to accomplish?
When adding a new item in the hierarchy the item form will stay open for the next entry.
What approach did you choose and why?
I added the additional rendering of the item form for the turbo stream response to
admin/custom_fields/hierarchy/items#create.