Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#59037] Primerize "Log time" dialog #17268

Draft
wants to merge 58 commits into
base: dev
Choose a base branch
from
Draft

[#59037] Primerize "Log time" dialog #17268

wants to merge 58 commits into from

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented Nov 25, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/59037

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

ToDos

  • User input field generates the wrong input name for the hidden input. Should be time_entry[custom_field_values][14][] is timeentry[custom_field_values][14][]
  • User select adds an empty component wrapper for the hidden input field, this shows up in the UI as a seperator

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch 9 times, most recently from 1b80f81 to c1fe43b Compare December 3, 2024 08:58
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch 6 times, most recently from 99ba88e to 5365457 Compare December 10, 2024 10:17
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 10:31 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 6d8d0cc to 2a5815e Compare December 10, 2024 15:19
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 15:19 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 2a5815e to b4eda15 Compare December 10, 2024 15:35
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 15:35 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 16:18 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 286eb05 to 3bcc56f Compare December 11, 2024 09:02
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 09:03 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 15:55 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 5f3398a to 82be505 Compare December 11, 2024 15:55
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 16:09 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 12, 2024 09:52 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 6080475 to 5c36cf0 Compare December 12, 2024 11:22
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 12, 2024 11:23 Inactive
@klaustopher
method to show caption when we are +1 day
f4c1782
@klaustopher
Add conversion from HH:mm format to integer
770b5ae
@klaustopher
add functionality to chronic duration to parse 8:15 to 8hours 15minut…
b4c34c3 
…es instead of 8minutes 15seconds
@klaustopher
add time calculation logic
ad19442
@klaustopher
switch to native html time input element
ba055e4
@klaustopher
fix behavior when we have disabled time tracking inputs
aac1acf
@klaustopher
make rubocop happy
f2645c2
@klaustopher
use i18n for day diff
ba842db
@klaustopher
render chronic duration in input field so that input does not suddenl…
2cbe1d6 
…y change
@klaustopher
Make the dialog more usable
a08dfcd
@klaustopher
fix form handling
0d3db3a
@klaustopher
split form into seperate fields
a7a6379
@klaustopher
use specific work package apis and call turbo action to replace activ…
b4177ae 
…ities
@klaustopher
render the activity form
0ba42cc
@klaustopher
remove label
b94bb00
@klaustopher
Add the new dialog the calendar widget
79fd5ea
@klaustopher
add new time entry modal to the context menu within a work package
bf6728d
@klaustopher
use the new dialog in the costs report as well
42742a0
@klaustopher
extract finder stuff into before actions
db1ed52
@klaustopher
make start and end time required conditionally
28b12b2
@klaustopher
Use i18n for the dialog title and main button
22c7c67
@klaustopher
activity form in the turbo endpoint
989c177
@klaustopher
get rid of component wrapping the activity form
e290191
@klaustopher
replace form when work package has changed
259f71e
@klaustopher
form knows when to render the user and work package field
0971d1f
@klaustopher
emit a custom event when the dialog is closed
49642e0
@klaustopher
reload the costs page when the time entry is edited
6e49d28
@klaustopher
fix 2 issues in the dialog
79a82db 
- when changing the workpackage on an edit form, the `method` was still overridden to `PATCH`
- when the work package field is already populated we cause a redundant request to the backend to refresh the form
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from dbb970c to 79a82db Compare December 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pullpreview
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klaustopher