Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: undefined method serialized for nil in ldap tls option migration #17271

Open
wants to merge 2 commits into
base: release/15.0
Choose a base branch
from

Conversation

machisuji
Copy link
Member

This fix addresses a problem when migrating from OpenProject 12 to 14 or later.

Yet another example for why you should try to avoid model code in migrations.

…option migration

the 'ldap_tls_options' setting does no longer exist and has therefore no format de
fined in the current code

we also fixed the value/deserialize to handle this more gracefully, but for good measure we also just pick the value directly here because that is more robust
@machisuji machisuji changed the title Fix/undefined method serialized for nil in ldap tls option migration Fix: undefined method serialized for nil in ldap tls option migration Nov 25, 2024
Copy link

1 Warning
⚠️ This PR has migration-related changes on a release branch. Ping @opf/operations

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant