Enable morphing for turbo drive #17296
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
changed the title
ulferts
force-pushed
the
code-maintenance/59779-enable-morphing-for-turbodrive
branch
3 times, most recently
from
486ee94 to
501d8d5
Compare
ulferts
force-pushed
the
code-maintenance/59779-enable-morphing-for-turbodrive
branch
from
5ab5627 to
4e1e337
Compare
dombesz
reviewed
Dec 18, 2024
| const element = event.target as HTMLElement; | ||
|
|
||
| // In case the element is an OpenProject custom dom element, morphing is prevented. | ||
| if (element.tagName.startsWith('OPCE-')) { |
There was a problem hiding this comment.
According to this #17223 (comment) , it would be advisable to use toUpperCase for comparing the tagname.
Suggested change
| if (element.tagName.startsWith('OPCE-')) { | |
| if (element.tagName.toUpperCase().startsWith('OPCE-')) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59779
What are you trying to accomplish?
Enable morphing with TurboDrive without breaking functionality.
What approach did you choose and why?
Merge checklist