[OP#59913] Add couple missing locale keys #17357
Conversation
top4ek
changed the title
top4ek
changed the title
There was a problem hiding this comment.
Thank you for providing missing translation keys. I left two comments that would be nice to be addressed before we merge this change.
Also note that the tests are failing right now:
1) I18n files are normalized
Failure/Error: expect(non_normalized).to be_empty, error_message
The following files need to be normalized:
modules/storages/config/locales/en.yml
Please run `i18n-tasks normalize' to fix
I hope that running this rake task will fix the failures.
Note: I will probably not be around to merge these changes until beginning of next year. Rest assured that I will keep this tab open in my browser and make sure to look at this PR again once I get back to work.
config/locales/en.yml
Outdated
| @@ -847,6 +847,7 @@ en: | |||
| is_required: "Required" | |||
| max_length: "Maximum length" | |||
| min_length: "Minimum length" | |||
| content_right_to_left: "Left-to-Right content" | |||
There was a problem hiding this comment.
Can you double check that the translation is correct? The key is "right-to-left", but the translation is "left-to-right".
config/locales/en.yml
Outdated
| @@ -4240,6 +4244,8 @@ en: | |||
| builtin: Built-in instance application | |||
| confidential: Confidential | |||
| singular: "OAuth application" | |||
| scope: "Scopes:" | |||
There was a problem hiding this comment.
Not an error introduced in this PR, but I noticed that it seemed inconsistent to see only scopes with a trailing : here. And indeed it's also inconsistent in the UI:
I'd suggest to drop the colon here, so that it doesn't slip into all translations before being fixed.
|
Thanks for findings — fixed.
Interesting feature — it just moved one key little bit higher inside yaml. But still has inconsistency with quote style.
NP. We have saying used on whole December: "Let's do it after holidays" :) Some time it means May holidays :) |
OP#59913
What are you trying to accomplish?
Add missing attribute in en locale so it could be translated via crowdin.