Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the life cycle dialog #17502

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Dec 19, 2024

Ticket

https://community.openproject.org/wp/60330

What are you trying to accomplish?

Improve the UX of date pickers in modals i.e. on the lifecycle modal:

  • The date picker can now reach out of the modal which prevents the modal needing to increase and the user to scroll to the added content

Screenshots

Kapture 2024-12-19 at 21 21 14

What approach did you choose and why?

The approach is to append the date picker to the modal. However, that is not enough. The date picker dom element also needs to be leveraged to the top-layer which is done right after opening the date picker. Positioning can easily be fixed by removing their top margin.

Because of the backdrop added when moving the date picker to the top layer, this move to the top layer needs to be repeated also when the input is clicked on again as that is treated as a click on the backdrop which removes an item from the top layer.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@ulferts ulferts force-pushed the feature/60330-optimize-lifecycle-modal-ux branch from ede9444 to 89a780c Compare December 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant