Fix title being set without base title #17515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
fix/angular-title-setting
branch
from
bdc8740 to
932e828
Compare
cbliard
approved these changes
Dec 23, 2024
cbliard
force-pushed
the
fix/angular-title-setting
branch
from
4575180 to
d42c373
Compare
|
I rebased onto |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you go to the My Page, the title is not being set using the
Setting.app_title. If you then move to Overview, the title is still lost.Pushing the title from the backend has some advantages, that allows us to always set a "more correct" title. This changes some specs that expected a title to not contain a module (as angular would replace it), to now have it correctly.
https://community.openproject.org/work_packages/60371