Skip to content

[#57052] Add optimistic locking to oauth_client_tokens #66

[#57052] Add optimistic locking to oauth_client_tokens

[#57052] Add optimistic locking to oauth_client_tokens #66

GitHub Actions / rubocop succeeded Aug 9, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (14)

app/controllers/my_controller.rb|138 col 3| Assignment Branch Condition size for generate_rss_key is too high. [<4, 18, 1> 18.47/17]
app/controllers/my_controller.rb|257 col 31| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/controllers/my_controller_spec.rb|57 col 9| Prefer expect(response).to have_http_status(404) over expect(response.status).to eq 404.
spec/controllers/my_controller_spec.rb|99 col 48| Avoid instance variables - use let, a method call, or a local variable (if possible).
spec/controllers/my_controller_spec.rb|179 col 9| Prefer using be_auto_hide_popups matcher over auto_hide_popups?.
spec/controllers/my_controller_spec.rb|245 col 5| Empty example group detected.
spec/controllers/my_controller_spec.rb|245 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/features/users/my_spec.rb|63 col 5| Do not use expect in before hook
spec/features/users/my_spec.rb|84 col 11| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/features/users/my_spec.rb|112 col 36| Prefer string interpolation to string concatenation.
spec/features/users/my_spec.rb|315 col 54| Interpolation in single quoted string detected. Use double quoted strings if you need interpolation.
spec/features/users/my_spec.rb|435 col 11| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/support/vcr.rb|39 col 5| Avoid stubbing using allow_any_instance_of.
spec/support/vcr.rb|40 col 5| Avoid stubbing using allow_any_instance_of.