Check work package version

Update OIDC configuration UI #940

Sign in to view logs

GitHub Actions / rubocop failed Oct 11, 2024 in 1s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (30)

modules/openid_connect/app/controllers/openid_connect/providers_controller.rb|50 col 131| Line is too long. [142/130]
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|43 col 7| Assignment Branch Condition size for after_validate is too high. [<9, 32, 12> 35.34/17]
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|43 col 7| Perceived complexity for after_validate is too high. [11/8]
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|74 col 49| Avoid manipulating ActiveModel errors as hash directly.
modules/openid_connect/app/services/openid_connect/sync_service.rb|51 col 5| Assignment Branch Condition size for call is too high. [<9, 20, 2> 22.02/17]
modules/openid_connect/spec/factories/provider_factory.rb|10 col 9| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|10 col 17| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|11 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|11 col 18| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|12 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|12 col 19| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|13 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|13 col 22| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|14 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|14 col 23| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|15 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|15 col 23| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|16 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|16 col 24| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|17 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|17 col 27| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|18 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|18 col 30| Surrounding space missing for operator =>.
modules/openid_connect/spec/factories/provider_factory.rb|19 col 8| Align the keys of a hash literal if they span more than one line.
modules/openid_connect/spec/factories/provider_factory.rb|19 col 32| Surrounding space missing for operator =>.
modules/openid_connect/spec/seeders/env_data/openid_connect/provider_seeder_spec.rb|33 col 1| Spec path should end with env_data/open_id_connect/provider_seeder*_spec.rb.
spec/services/users/register_user_service_spec.rb|105 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|118 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|133 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|149 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Filtered Findings (0)

Annotations

Check notice on line 50 in modules/openid_connect/app/controllers/openid_connect/providers_controller.rb

github-actions / rubocop

[rubocop] modules/openid_connect/app/controllers/openid_connect/providers_controller.rb#L50 <Layout/LineLength>

Line is too long. [142/130]

Raw output


            modules/openid_connect/app/controllers/openid_connect/providers_controller.rb:50:131: C: Layout/LineLength: Line is too long. [142/130]

Check notice on line 85 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L43-L85 <Metrics/AbcSize>

Assignment Branch Condition size for after_validate is too high. [<9, 32, 12> 35.34/17]

Raw output


            modules/openid_connect/app/services/openid_connect/providers/update_service.rb:43:7: C: Metrics/AbcSize: Assignment Branch Condition size for after_validate is too high. [<9, 32, 12> 35.34/17]

Check notice on line 85 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L43-L85 <Metrics/PerceivedComplexity>

Perceived complexity for after_validate is too high. [11/8]

Raw output


            modules/openid_connect/app/services/openid_connect/providers/update_service.rb:43:7: C: Metrics/PerceivedComplexity: Perceived complexity for after_validate is too high. [11/8]

Check warning on line 74 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L74 <Rails/DeprecatedActiveModelErrorsMethods>

Avoid manipulating ActiveModel errors as hash directly.

Raw output


            modules/openid_connect/app/services/openid_connect/providers/update_service.rb:74:49: W: Rails/DeprecatedActiveModelErrorsMethods: Avoid manipulating ActiveModel errors as hash directly.

Check notice on line 66 in modules/openid_connect/app/services/openid_connect/sync_service.rb

github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/sync_service.rb#L51-L66 <Metrics/AbcSize>

Assignment Branch Condition size for call is too high. [<9, 20, 2> 22.02/17]

Raw output


            modules/openid_connect/app/services/openid_connect/sync_service.rb:51:5: C: Metrics/AbcSize: Assignment Branch Condition size for call is too high. [<9, 20, 2> 22.02/17]

Check notice on line 10 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L10 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:10:9: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 10 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L10 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:10:17: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 11 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L11 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:11:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 11 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L11 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:11:18: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 12 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L12 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:12:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 12 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L12 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:12:19: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 13 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L13 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:13:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 13 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L13 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:13:22: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 14 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L14 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:14:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 14 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L14 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:14:23: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 15 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L15 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:15:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 15 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L15 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:15:23: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 16 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L16 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:16:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 16 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L16 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:16:24: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 17 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L17 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:17:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 17 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L17 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:17:27: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 18 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L18 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:18:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 18 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L18 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:18:30: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

Check notice on line 19 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L19 <Layout/HashAlignment>

Align the keys of a hash literal if they span more than one line.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:19:8: C: Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

Check notice on line 19 in modules/openid_connect/spec/factories/provider_factory.rb

github-actions / rubocop

[rubocop] modules/openid_connect/spec/factories/provider_factory.rb#L19 <Layout/SpaceAroundOperators>

Surrounding space missing for operator `=>`.

Raw output


            modules/openid_connect/spec/factories/provider_factory.rb:19:32: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=>`.

View more details on GitHub Actions