-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: markdown #1357
refactor: markdown #1357
Conversation
todo: - fix the automatic generation of the table of contents to be used in the marketplace too
|
@floriandwt can you copy the pacakge-lock.json fom the main branch, delete the package-lock.json in this branch, and run the lock file got overwritten or something leading to "15.000 line of change" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall as expected. One remark:
The mermaid feature seems to introduce a lot (too much) complexity. I assume that you felt at one point "hm, adding a playwright dependency doesn't seem right". Speak up and discuss with your team members. Your gut feeling is usually right. The engineering goal is not to support any feature but to support a feature that is worth it given the compexity it introduces. Otherwise, the project will suffer from unreasonable long term maintainence burden(s).
inlang/source-code/website/src/pages/blog/@id/index.page.server.tsx
Outdated
Show resolved
Hide resolved
inlang/source-code/website/src/pages/blog/@id/index.page.server.tsx
Outdated
Show resolved
Hide resolved
@samuelstroschein almost all remaining should be solved now, I will finish getting rid of mermaid on Monday and move the new tableOfContents function to the client then. Edit: + introduce Gallery, but this is a smaller task anyway. |
This PR introduces a new markdown rendering enabling more interop. between e.g. GitHub Readmes, Marketplace documentations, and can be used in further use cases. See #1302