update IpamDiffParser to use new diff #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #4870 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-11062024-ipam-new-diff
branch
3 times, most recently
from
fbaf92a to
5a80731
Compare
ajtmccarty
force-pushed
the
ajtm-11062024-ipam-new-diff
branch
from
5a80731 to
8ba7fd6
Compare
dgarros
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFC-878
update
IpamDiffParserto use the new diffalso update some of the Ipam integration tests b/c some of them were actually doing something illegal and allowing a rebase when conflicts should have prevented it
I saw one of the ipam integration tests fail 2 times over ~50 runs, but was unable to reproduce it reliably. I suspect that something is going wrong in Ipam reconciliation depending on the order in which the reconciliation tasks for each updated IP-related node are run, but I am not certain