IFC-592 Merge schemas when loading them from files #5482
+191
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5482 will not alter performanceComparing Summary
|
gmazoyer
commented
Jan 16, 2025
| @@ -41,6 +41,7 @@ Jinja2 = "^3" | |||
| gitpython = "^3" | |||
| pyyaml = "^6" | |||
| toml = "^0.10" | |||
| dulwich = "^0.21" | |||
There was a problem hiding this comment.
Is this needed? This is a dependency which is supposed to be on the Python SDK.
gmazoyer
changed the title
dgarros
approved these changes
Jan 16, 2025
ogenstad
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM, one comment though with this approach if we later want to provide detailed error reports if part os the payload is invalid it seems like it might get harder to indicate where the actual error is. We could of course show it against the combined schema. But we can perhaps cross that bridge when we get there.
gmazoyer
changed the title
ajtmccarty
approved these changes
Jan 16, 2025
When loading multiple schemas files, they used to be imported one by one. With this change, the files are now parsed as schemas and then merged together in order to produce a single schema to load. The merge is performed one by one in the order of the files. This means that the schema coming last will overwrite the previous one if they refer to the same nodes.
gmazoyer
force-pushed
the
gma-20240116-4188
branch
from
c35ce4e to
5ee44f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4188
When loading multiple schemas files, they used to be imported one by one. With this change, the files are now parsed as schemas and then merged together in order to produce a single schema to load. The merge is performed one by one in the order of the files. This means that the schema coming last will overwrite the previous one if they refer to the same nodes.