-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9654] fix: Default to VUID without user(id) as Provider prop #229
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3f7f916
feat: Use vuid for user.id if user? provided
mikechu-optimizely 9ed3464
test: Add missing Optimizely.getVuid jest.fn mock
mikechu-optimizely e8e75cd
refactor: Move set user to componentDidMount
mikechu-optimizely 96ccc41
test: Update for rejected optimizely.onReady
mikechu-optimizely a649e6f
refactor: Change use sync componentDidMount() lifecycle method
mikechu-optimizely bbd1d5f
fix: remove localStorage & getVuid use
mikechu-optimizely ba38dc1
fix: Separate responsiblities of getUserContextInstance
mikechu-optimizely aa573bd
refactor: getUserContextWithOverrides
mikechu-optimizely 2ca6d23
fix: Update ReactSDKClient interface
mikechu-optimizely 170b02a
refactor: Update warns + clean up
mikechu-optimizely 8706614
refactor: DRY + moves + warn updates
mikechu-optimizely 1922259
refactor: No wait fetchQualifiedSegments on setUser
mikechu-optimizely 8bbda64
fix(user): Allow latent setting of user
mikechu-optimizely d10f7b6
test: WIP Fixing tests
mikechu-optimizely 7c760b5
nit: Format with Prettier
mikechu-optimizely df4de19
nit: More formatting with Prettier
mikechu-optimizely 6736c30
test: Fix now that instantiation is now async
mikechu-optimizely 0ac4de4
fix: Remove use sync lifecycle method
mikechu-optimizely d77f64e
test: WIP graceful promise reject test failing
mikechu-optimizely aae3fff
test: WIP replace timers in tests
mikechu-optimizely 04aeb61
test: Better timeout handling in jest
mikechu-optimizely 7ab3b8b
refactor: Move client onReady check slightly
mikechu-optimizely b4beae4
fix: Use FeatureVariableValue; Remove excess checks; Better user assi…
mikechu-optimizely 0a8b997
refactor: Remove FeatureVariableValue for now
mikechu-optimizely ed35b6d
test: Fix code supported by tests
mikechu-optimizely 33663c5
refactor: Move getUserWithOverrides() back to position
mikechu-optimizely b3f73f4
refactor: Move isReady() for easier PR
mikechu-optimizely d8d681c
refactor: Change back to getUserContext()
mikechu-optimizely 58d47c8
refactor: Make set and make user context private
mikechu-optimizely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this introduces a bug and breaks SSR:
#234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal ticket opened and put into this sprint.