[FSSDK-9776] handle duplicate experiment key #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
previously approved these changes
Nov 27, 2023
Tests/OptimizelyTests-APIs/OptimizelyClientTests_OptimizelyConfig.swift
Outdated
Show resolved
Hide resolved
jaeopt
requested changes
Nov 28, 2023
Tests/OptimizelyTests-APIs/OptimizelyClientTests_OptimizelyConfig.swift
Outdated
Show resolved
Hide resolved
|
Can I use this as a reference for doing other language SDK updates? |
Sure |
|
Thanks for the lint fixes. This helps my need for meticulous code. 😄 Also thanks for the reference implementation for me to copy 😁 |
muzahidul-opti
added a commit
that referenced
this pull request
Dec 5, 2023
Logged for Duplicate keys (cherry picked from commit c2af8fe)
muzahidul-opti
added a commit
that referenced
this pull request
Dec 6, 2023
* Upload task body issue fixed (#521) (cherry picked from commit a375e2b) * [FSSDK-9776] handle duplicate experiment key (#523) Logged for Duplicate keys (cherry picked from commit c2af8fe) * [FSSDK-9709] feat: App privacy manifest file added (#522) * Update CHANGELOG.md * Update README.md * Update swift.yml * Update run_unit_tests.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When duplicate experiment key found in the data file, SDK returns correct experiment map in OptimizelyConfig
Test plan
Issues