✨ feat: Use Vite instead of webpack #641
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
reviewed
Sep 30, 2023
optuna_dashboard/index.html
Outdated
| @@ -1,75 +1,123 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Should we list this file on .gitignore?
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 62.45% 62.44% -0.02%
==========================================
Files 35 35
Lines 2224 2234 +10
==========================================
+ Hits 1389 1395 +6
- Misses 835 839 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has not seen any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Vite was installed in place of Webpack.
The server is started with Vite in development and served as a static file built with Vite in production by the API server.
Maintenance has been made a bit easier by cutting out the source code for the web client, which used to be in
optuna_dashboard/ts, intooptuna_dashboard_client/web.optuna_dashboard/ts, it should be possible to remove package.json and other files in the root directory. Also, I would like to move the TypeScript related test files to a new directory.