Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply formatter and follow the Optuna conventions #133

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Apply formatter and follow the Optuna conventions #133

merged 4 commits into from
Jul 1, 2024

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

As the comet integration has not followed the Optuna convention, I applied the formatter.

Description of the changes

  • Apply formatter
  • Use __future__.annotations

HideakiImamura
HideakiImamura approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 9828e34 into optuna:main Jul 1, 2024
31 checks passed
@nzw0301 nzw0301 added this to the v4.0.0 milestone Jul 1, 2024
@not522 not522 added the code-fix Change that does not change the behavior, such as code refactoring. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees
No one assigned
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Milestone
v4.0.0-b0
Development

Successfully merging this pull request may close these issues.
4 participants
@nabenabe0928 @HideakiImamura @not522 @nzw0301