Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Integration Testing #90

Closed
wants to merge 4 commits into from
Closed

Conversation

DanielAvdar
Copy link
Contributor

Motivation

Split all CIs for each integration module #30

Description of the changes

Integration-Specific Test Modules

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89b3058) 72.61% compared to head (d833e96) 72.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          39       39           
  Lines        3334     3334           
=======================================
  Hits         2421     2421           
  Misses        913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielAvdar DanielAvdar marked this pull request as ready for review February 18, 2024 09:01
@nabenabe0928
Copy link
Collaborator

nabenabe0928 commented Feb 19, 2024

@DanielAvdar Thank you for this PR, but as this PR involves a lot of changes in CI, our team decided to solve this issue by ourselves.
Sorry for the inconvenience, we should have mentioned this in the issue description, but we are always welcome to see any PRs for the issues with the contribution welcome label.

Note that what we would like to do is to not change the directory structure, but to divide the yaml file for all the tests into yaml files for each integration module, which means that the new PR is gonna be completely an orthogonal work of yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants