Remove the deprecated decorator of KerasPruningCallback
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 72.61% 72.65% +0.03%
==========================================
Files 39 39
Lines 3334 3331 -3
==========================================
- Hits 2421 2420 -1
+ Misses 913 911 -2 ☔ View full report in Codecov by Sentry. |
nzw0301
force-pushed
the
remove-keras-callback-deprecation
branch
from
e1810ad
to
5449518
Compare
nzw0301
force-pushed
the
remove-keras-callback-deprecation
branch
from
5449518
to
2ad1839
Compare
|
This pull request has not seen any recent activity. |
github-actions
bot
added
stale
|
I'll review this PR in a few days. |
HideakiImamura
added
the
code-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #91. Technically, the integration tests do not use Keras 3.0 yet due to tensorflow; even though Keras 3.0 has been stable, the latest stable tensorflow 2.15.0 uses Keras 2.* and tensorflow 2.16, which is not released yet, will use Keras 3.0 by default. However I confirmed that the tests for the callback with Keras 3.0 and pytorch/jax run without errors.
Description of the changes
Inputclass rather than the deprecated way.