Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out analytics in CI #53

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

toshihikoyanase
Copy link
Member

Motivation

We may want to avoid counting the package download during CI.

Description of the changes

Set OPTUNAHUB_NO_ANALYTICS="1"

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (7ca1ca2) to head (2c07d3f).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   90.47%   81.90%   -8.58%     
==========================================
  Files           4        4              
  Lines         105      105              
==========================================
- Hits           95       86       -9     
- Misses         10       19       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

Perhaps, we also need to set the environmental variable to mac-tests.
https://github.com/optuna/optunahub/blob/main/.github/workflows/mac-tests.yml

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit 5cc1871 into optuna:main Aug 21, 2024
11 checks passed
toshihikoyanase added a commit to toshihikoyanase/optunahub that referenced this pull request Aug 27, 2024
@toshihikoyanase toshihikoyanase deleted the opt-out-analytics-in-ci branch August 27, 2024 08:18
y0z added a commit that referenced this pull request Aug 27, 2024
@y0z y0z added the CI Continuous integration. label Aug 28, 2024
@y0z y0z added this to the v0.1.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants