-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SimpleBaseSampler and remove load settings propagation #55
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 81.90% 81.95% +0.05%
==========================================
Files 4 6 +2
Lines 105 133 +28
==========================================
+ Hits 86 109 +23
- Misses 19 24 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. The change looks good to me.
I confirmed that optunahub.samplers.SimpleBaseSampler
actually worked with the whale optimization.
Since this PR includes some breaking changes, it might be kind to cover the changes regarding propagation in the PR title.
|
||
|
||
class SimpleBaseSampler(BaseSampler, abc.ABC): | ||
"""A simple base class to implement user-defined samplers.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Note] This implementation is a copy of https://github.com/optuna/optunahub-registry/blob/main/package/samplers/simple/__init__.py, except for this docstring.
Motivation
We've decided to move
SimpleBaseSampler
fromoptunahub-registry
tooptunahub.samplers
and remove settings propagation. This PR introducesSimpleBaseSampler
and removes things that are no longer needed.Description of the changes
optunahub.samplers.SimpleBaseSampler
optunahub.samplers.SimpleBaseSampler
load_module
andload_local_module