Test: deposit test #692
Merged
Test: deposit test #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Let's try to make code coverage, %branches 90% or more @daryakaviani |
12 tasks
daryakaviani
approved these changes
Oct 31, 2022
|
|
||
| assertEq(bullStrategy.balanceOf(user1), crabToDepositInitially); | ||
| assertEq(IEulerDToken(dToken).balanceOf(address(bullStrategy)), usdcToBorrow); | ||
| assertTrue(wethToLend.sub(IEulerEToken(eToken).balanceOfUnderlying(address(bullStrategy))) <= 1); |
There was a problem hiding this comment.
This is fine for this test, but if you add a fuzzing one, note that sometimes it gets to 2 wei difference.
|
|
||
| assertEq(bullStrategy.balanceOf(user1).sub(userBullBalanceBefore), bullToMint); | ||
| assertEq(IEulerDToken(dToken).balanceOf(address(bullStrategy)).sub(usdcToBorrow), usdcToBorrowSecond); | ||
| assertTrue(wethToLendSecond.sub(IEulerEToken(eToken).balanceOfUnderlying(address(bullStrategy)).sub(wethToLend)) <= 1); |
There was a problem hiding this comment.
This is fine for this test, but if you add a fuzzing one, note that sometimes it gets to 2 wei difference.
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: deposit test
Should be merged after #690
Description
This PR add a second test case for
deposit()Type of change
How Has This Been Tested
Please describe how to test to verify the changes. Provide instructions so we can reproduce.
FE Checklist
User Facing Checklist