Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert code that uses legacy SQLAlchemy API to version 2.0 #31

Merged
merged 2 commits into from
Oct 10, 2024
Merged

refactor: Convert code that uses legacy SQLAlchemy API to version 2.0 #31

merged 2 commits into from
Oct 10, 2024

Conversation

y-masaomi
Copy link
Contributor

✍ Description

refactor: Convert code that uses legacy SQLAlchemy API to version 2.0.

@shgokita
Copy link
Contributor

it looks good. I confirmed following operations in cloud environment.

  • user api
    • GET /devices
    • GET /devices/{deviceID}
    • GET /results/sampling|estimation/{taskID}
    • GET /tasks/sampling|estimation/{taskID}
    • GET /tasks/sampling|estimation/{taskID}/status
  • provider api
    • GET /internal/tasks/{taskID}
    • GET /internal/tasks/unfetched
    • PATCH /internal/tasks/{taskID}

orangekame3
orangekame3 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@orangekame3 orangekame3 added the refactor Code changes that neither fix a bug nor add a feature label Oct 10, 2024
@orangekame3 orangekame3 merged commit b3816d9 into oqtopus-team:develop Oct 10, 2024
1 check failed
@y-masaomi y-masaomi deleted the issue/#151 branch October 10, 2024 01:39
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangekame3 orangekame3 orangekame3 approved these changes

@shgokita shgokita Awaiting requested review from shgokita shgokita is a code owner

Assignees

@y-masaomi y-masaomi

Labels
refactor Code changes that neither fix a bug nor add a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-masaomi @shgokita @orangekame3