chore: refactor provenance available check #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
benmss
force-pushed
the
benmss/refactor-provenance-checks
branch
2 times, most recently
from
c92c5fa
to
55f4571
Compare
benmss
force-pushed
the
benmss/refactor-provenance-checks
branch
from
5e36475
to
a185751
Compare
tromai
reviewed
Jul 25, 2024
tromai
reviewed
Jul 25, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
…ix more integration test related issues Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
…check Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
benmss/refactor-provenance-checks
branch
from
464efd6
to
cbc7376
Compare
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
Aug 1, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
Aug 2, 2024
tests/integration/cases/micronaut-projects_micronaut-test/micronaut-test.dl
Outdated
Show resolved
Hide resolved
tromai
reviewed
Aug 2, 2024
tromai
reviewed
Aug 2, 2024
tromai
reviewed
Aug 2, 2024
…t fails to find provenance; check for tag commit value error; remove redundant function Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
tromai
reviewed
Aug 6, 2024
tromai
reviewed
Aug 6, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
reviewed
Aug 12, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
approved these changes
Aug 13, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the provenance available check so that the provenance finding functions are all performed as part of analysis instead of within the check itself. The check is then free to reference the pre-discovered provenance, if any.