[GR-18163] Ruby 2.7: Add Complex#<=> (#2161)

PullRequest: truffleruby/2170
oracle · Nov 17, 2020 · cad1ca4 · cad1ca4
2 parents 666041d + 0b9e9e7
commit cad1ca4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ Compatibility:
 * Implement `Range#minmax`.
 * Pass more `Enumerator::Lazy#uniq` and `Enumerator::Lazy#chunk` specs (#2146, @LillianZ).
 * Implement `Enumerator#produce` (#2160, @zverok)
+* Implement `Complex#<=>` (#2004, @ssnickolay).
 
 Performance:
 

diff --git a/spec/tags/core/complex/comparision_tags.txt b/spec/tags/core/complex/comparision_tags.txt
diff --git a/src/main/ruby/truffleruby/core/complex.rb b/src/main/ruby/truffleruby/core/complex.rb
@@ -36,7 +36,7 @@
 
 class Complex < Numeric
 
-  undef_method :%, :<, :<=, :<=>, :>, :>=, :between?, :clamp, # comparable
+  undef_method :%, :<, :<=, :>, :>=, :between?, :clamp, # comparable
                :div, :divmod, :floor, :ceil, :modulo, :remainder,
                :round, :step, :truncate, :i, :negative?, :positive?
 
@@ -373,6 +373,16 @@ def marshal_load(ary)
     self
   end
 
+  def <=>(other)
+    if imag == 0 && other.kind_of?(Numeric)
+      if other.kind_of?(Complex) && other.imag == 0
+        real <=> other.real
+      elsif other.real?
+        real <=> other
+      end
+    end
+  end
+
   I = Complex(0, 1)
 
 end
diff --git a/test/mri/excludes/Complex_Test.rb b/test/mri/excludes/Complex_Test.rb
@@ -16,4 +16,3 @@
 exclude :test_rationalize, "needs investigation"
 exclude :test_Complex_with_invalid_exception, "needs investigation"
 exclude :test_conv, "needs investigation"
-exclude :test_cmp, "needs investigation"