Showing fractional seconds in Time#inspect #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to change the behaviour of `#inspect` without affecting `#to_s`.
This creates the opportunity to append the fractional time first.
Although the Ruby specs don’t demonstrate it, we need to strip the trailing zeros.
chrisseaton
changed the title
eregon
approved these changes
Dec 18, 2020
| str.force_encoding Encoding::US_ASCII | ||
| end | ||
|
|
||
| def to_s | ||
| if gmt? | ||
| str = strftime('%Y-%m-%d %H:%M:%S UTC') | ||
| else | ||
| str = strftime('%Y-%m-%d %H:%M:%S %z') | ||
| end | ||
| str.force_encoding Encoding::US_ASCII |
There was a problem hiding this comment.
It seems better to refactor to_s to also use the str << (gmt? ? ' UTC' : strftime(' %z')) approach to make comparison easier, I'll do that.
There was a problem hiding this comment.
Thank you. I wasn’t sure of the performance impact of mutating the string so I erred on the side of leaving it alone, but I agree it’s better to make it look the same if there’s no downside.
|
(I'll fix the lint issue) |
graalvmbot
pushed a commit
that referenced
this pull request
Dec 18, 2020
PullRequest: truffleruby/2272
|
I feel like this got merged - why didn't the bot close it? |
|
Sorry for the inconvenience, and thanks for sorting it out. I’ll beware of this in future. |
|
No worry :) |
graalvmbot
pushed a commit
that referenced
this pull request
Dec 21, 2020
…2194) PullRequest: truffleruby/2278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating on behalf of @tomstuart.
Showing fractional seconds in Time#inspect is Ruby feature #15958, required for Ruby 2.7 compatibility per #2004. This PR satisfies one of the two ruby/spec tests for Time#inspect.
The other spec is probably too MRI specific. We'll address that elsewhere.
Shopify#1