-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-57603] Import Ruby 3.3.5 #3682
Conversation
6d455bc
to
1f8b540
Compare
681a9ab
to
337326c
Compare
96bf279
to
d4d4944
Compare
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
112cf5e
to
0351e07
Compare
ac457f1
to
1893915
Compare
…d in exclude files We've encountered an issue with adding this guard when a test name contains platform (e.g. 'linux' or 'darwin'). If such a test fails then it's excluded on the detected platform but is still run on the other one. So may not be skipped/omitted explicitly and fail. Example of such test - TestThread#test_thread_native_thread_id_across_fork_on_linux.
Example of error message that leads to a Ruby exception: ``` 1) Failure: TestIRB::IrbIOConfigurationTest::AutoIndentationTest#test_oneliner_def_in_multiple_lines [/Users/andrykonchin/projects/truffleruby-ws/truffleruby/test/mri/tests/irb/test_irb.rb:540]: Incorrect spaces calculation for line after the current line: ``` def a()=[ > ``` All lines: ``` def a()=[ ``` . <2> expected but was <4>. ``` Leads to the following error: ``` tool/parse_mri_errors.rb:446:in `block in process_test_failures!': no implicit conversion of nil into String (TypeError) error_display << ' ' << error_lines[index] ^^^^^^^^^^^^^^^^^^ from tool/parse_mri_errors.rb:392:in `scan' from tool/parse_mri_errors.rb:392:in `process_test_failures!' from tool/parse_mri_errors.rb:492:in `<main>' ```
* jt retag rdoc: 6514.80s user 248.44s system 465% cpu 24:12.06 total * jt retag --together rdoc: 530.03s user 6.03s system 143% cpu 6:12.29 total * opt-in because in case of process crash, using --together means rerunning all tests from the beginning for each process crash. * Only show "Retaining:" if keeping any tag.
Fix trivial issues in the following MRI tests: - TestGemSpecification#test_self_stubs_for_lazy_loading - TestIRB::CompletionTest::RequireComepletionTest#test_complete_require_relative - TestIRB::LocaleTestCase#test_find - TestMkmfInstall#test_install_dirs
ruby-test-specs-darwin-amd64-latest and ruby-test-specs-darwin-amd64-stable CI jobs
…p#match? instead of Regexp#match
This is already skipped with #ifndef TRUFFLERUBY
1a61073
to
4f0edf9
Compare
No description provided.