Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set_env.erb #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update set_env.erb #27

wants to merge 1 commit into from

Conversation

gberche-orange
Copy link
Member

@gberche-orange gberche-orange commented May 21, 2021

expected behavior

As a paas-templates operator

  • in order to interactively execute helm commands
  • I need an easy way to get the required environment set up in my current shell

observe behavior

source /var/vcap/jobs/action/bin/set_env brings the side effect of turning set -e flag in the current interactive shell, existing the shell on the first command with non-zero exit status

#restore the exit mode when this file is sourced within an interactive shell

#restore the exit mode when this file is sourced within an interactive shell
@gberche-orange
Copy link
Member Author

feedback received from @poblin-orange :

  • care should be taken to restore the set -e for other scripts that might expect it
  • consider alternative to automatically source the environment file in the bosh user

https://github.com/orange-cloudfoundry/k3s-boshrelease/blob/dbce4740e120ebf0fb1f8113c85ed22c2c0915d6/jobs/k3s-agent/templates/bin/setup-user-env.erb#L1-L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant