Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): add dispatch GHA for snapcraft classic release #1256

Merged
merged 17 commits into from
May 14, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jan 29, 2024

What this PR does / why we need it:
This PR adds a Github Action which can be run manually to for snapcraft releasing.
image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1079

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (2d0431d) to head (b4e12c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1256   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         107      107           
  Lines        3806     3806           
=======================================
  Hits         3238     3238           
  Misses        339      339           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah
Copy link
Contributor Author

qweeah commented Jan 29, 2024

Making this PR draft since the login credential has not been added to repo secrets. (see instruction)

@qweeah qweeah marked this pull request as ready for review January 29, 2024 09:36
@qweeah qweeah marked this pull request as draft January 30, 2024 07:20
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added stale Inactive issues or pull requests and removed stale Inactive issues or pull requests labels Mar 16, 2024
@SamirPS
Copy link
Contributor

SamirPS commented Apr 7, 2024

@qweeah Do you need help for this PR ?

@qweeah
Copy link
Contributor Author

qweeah commented Apr 8, 2024

@qweeah Do you need help for this PR ?

Thanks @SamirPS, currently I don't need any help. I have walked through the build and publish part on Snapcraft side, just need to tune the release process to fit ORAS' release practice.

@qweeah qweeah marked this pull request as ready for review May 14, 2024 01:50
@qweeah qweeah changed the title ci(release): automated snapcraft classic release ci(release): add dispatch GHA for snapcraft classic release May 14, 2024
Signed-off-by: Billy Zha <[email protected]>
@qweeah
Copy link
Contributor Author

qweeah commented May 14, 2024

After this being merged, we still need to run below command to add the content of exported.txt to oras's Actions secret named STORE_LOGIN

snapcraft export-login --snaps=oras \
      --acls package_access,package_push,package_update,package_release \
      exported.txt

.github/workflows/release-snap.yml Outdated Show resolved Hide resolved
.github/workflows/release-snap.yml Outdated Show resolved Hide resolved
@qweeah qweeah requested a review from SamirPS May 14, 2024 08:49
.github/workflows/release-snap.yml Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit b1cb8ea into oras-project:main May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ORAS from snap can't authenticate with gcloud credential helper
3 participants