Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the configfile to match the oci v1 spec #77

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

lswith
Copy link
Contributor

@lswith lswith commented Apr 22, 2023

This PR updates the serialize/deserialize of the configfile to match the spec outlined here.

@lswith lswith force-pushed the config-file-error branch 3 times, most recently from e2b01b8 to e170c34 Compare April 22, 2023 04:58
Copy link
Contributor

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of changing the structs in this way, I'm referring to the usage of Optional.

I left some comments about minor changes

src/config.rs Outdated Show resolved Hide resolved
@flavio
Copy link
Contributor

flavio commented May 9, 2023

@thomastaylor312 , @bacongobbler: what do you think about this change?

lswith and others added 4 commits September 26, 2023 10:32
Signed-off-by: Luke Swithenbank <[email protected]>
Signed-off-by: Luke Swithenbank <[email protected]>
Use `rstest` to reduce code repetition

Signed-off-by: Flavio Castelli <[email protected]>
@flavio
Copy link
Contributor

flavio commented Sep 26, 2023

I've rebased against main and fixed the conflicts

@flavio
Copy link
Contributor

flavio commented Sep 26, 2023

merging, sorry for the delay

@flavio flavio merged commit 8ce32a1 into oras-project:main Sep 26, 2023
5 checks passed
@flavio flavio mentioned this pull request Nov 24, 2023
flavio added a commit to flavio/rust-oci-client that referenced this pull request Nov 24, 2023
What's Changed:
* client: Fix failed to pull ubuntu image from docker.io by @arronwy in oras-project#67
* Update rstest requirement from 0.16.0 to 0.17.0 by @dependabot in oras-project#70
* Bump actions/checkout from 3.3.0 to 3.4.0 by @dependabot in oras-project#69
* Bump actions/checkout from 3.4.0 to 3.5.0 by @dependabot in oras-project#73
* Change the visibility of `OciEnvelop.errors` to `pub` by @linyinfeng in oras-project#71
* Bump actions/checkout from 3.5.0 to 3.5.2 by @dependabot in oras-project#74
* make pushes concurrent and limit pull concurrency by @dicej in oras-project#72
* Update default `docker.io` registry by @radu-matei in oras-project#81
* Fix: Expose HTTP errors when pulling layers by @jsoverson in oras-project#82
* client: Return Stream for async_pull_blob API by @arronwy in oras-project#83
* chore(deps): Bump actions/checkout from 3.5.2 to 3.5.3 by @dependabot in oras-project#85
* fix(CI): address warnings of cargo deny by @flavio in oras-project#84
* consider ARCH as ppc64le when rust arch is powerpc64 by @Amulyam24 in oras-project#86
* chore(deps): Update rstest requirement from 0.17.0 to 0.18.1 by @dependabot in oras-project#88
* add optional artifactType to image manifest for oci v1.1 by @devigned in oras-project#89
* Higher-ranked lifetime error workaround by @linyinfeng in oras-project#90
* chore(deps): Bump actions/checkout from 3.5.3 to 3.6.0 by @dependabot in oras-project#91
* chore(deps): Bump actions/checkout from 3.6.0 to 4.0.0 by @dependabot in oras-project#92
* chore(deps): Bump actions/checkout from 4.0.0 to 4.1.0 by @dependabot in oras-project#94
* Improved Push Logic by @rbbl-dev in oras-project#93
* Update the configfile to match the oci v1 spec by @lswith in oras-project#77
* Conversion between a Config and a ConfigFile by @lswith in oras-project#76
* Enhance client to push blobs, mount blobs, and push raw manifests by @aochagavia in oras-project#66
* fix: bring back workaround for rustc by @flavio in oras-project#95
* implemented method to list tags by @rbbl-dev in oras-project#80
* feat(config.rs): add OS type for WASI Preview 1 by @vdice in oras-project#99
* chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1 by @dependabot in oras-project#100
* chore(deps): Update testcontainers requirement from 0.14 to 0.15 by @dependabot in oras-project#96
* feat: return auth token from Client::auth by @mattarnoatibm in oras-project#105

Signed-off-by: Flavio Castelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants