Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #428: default_gipass is not required if sysasmpassword and asmmonitorpassword are set #433

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/fragments/gipass.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
bugfixes:
- "default_gipass is not required if sysasmpassword and asmmonitorpassword are set (oravirt#433)"

3 changes: 2 additions & 1 deletion roles/oraswgi_install/tasks/assert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
ansible.builtin.assert:
quiet: true
that:
- default_gipass | length > 0
- default_gipass | length > 0 or sysasmpassword | default('',true) | length > 0
- default_gipass | length > 0 or asmmonitorpassword | default('',true) | length > 0
- oracle_install_version_gi is defined
- oracle_gi_cluster_type in ('STANDARD', 'STANDALONE')
tags: always
Expand Down
Loading