Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #436 Consider home was removed earlier, leaving REMOVED=T #437

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix for Issue #436 Consider home was removed earlier, leaving REMOVED=T #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
021074b
Consider home was removed earlier, leaving REMOVED=T
Apr 19, 2024
e330b10
changelog
Rendanic Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/home_state.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- "Consider home was removed earlier, leaving REMOVED=T (oravirt#437)"
2 changes: 1 addition & 1 deletion roles/oraswdb_install/tasks/install-home-db.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{%- endif %}" # noqa jinja[spacing]

- name: install_home_db | Check if DB-server is already installed
ansible.builtin.shell: cat "{{ oracle_inventory_loc }}/ContentsXML/inventory.xml" | grep -w {{ oracle_home_db }} | awk '{print $3}' | cut -f2 -d'"'
ansible.builtin.shell: grep -w {{ oracle_home_db }} "{{ oracle_inventory_loc }}/ContentsXML/inventory.xml" | grep -iv 'REMOVED=.T.' | awk '{print $3}' | cut -f2 -d'"'
# noqa risky-shell-pipe
register: existing_dbhome
changed_when: false
Expand Down
2 changes: 1 addition & 1 deletion roles/oraswgi_install/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
allow_duplicates: false

- name: install_home_gi | Check if GI is already installed
ansible.builtin.shell: cat "{{ oracle_inventory_loc }}/ContentsXML/inventory.xml" | grep -w {{ oracle_home_gi }} |awk '{print $3}' | cut -f2 -d'"'
ansible.builtin.shell: grep -w {{ oracle_home_gi }} "{{ oracle_inventory_loc }}/ContentsXML/inventory.xml" | grep -iv 'REMOVED=.T.' | awk '{print $3}' | cut -f2 -d'"'
# noqa command-instead-of-shell no-changed-when risky-shell-pipe
tags:
- always
Expand Down
Loading