Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maestro): adding test cases and fixes logic for handling events #2667

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

lpegoraro
Copy link
Contributor

No description provided.

@lpegoraro lpegoraro requested a review from etaques September 28, 2023 20:07
@lpegoraro lpegoraro self-assigned this Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #2667 (9b6a1de) into develop (418bb2b) will increase coverage by 8.68%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2667      +/-   ##
===========================================
+ Coverage    53.25%   61.93%   +8.68%     
===========================================
  Files           75       58      -17     
  Lines         5667     4724     -943     
===========================================
- Hits          3018     2926      -92     
+ Misses        2649     1798     -851     

see 17 files with indirect coverage changes

@lpegoraro lpegoraro marked this pull request as ready for review September 28, 2023 20:35
etaques
etaques previously approved these changes Sep 28, 2023
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

etaques
etaques previously approved these changes Sep 28, 2023
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etaques etaques merged commit 6c6caeb into orb-community:develop Sep 29, 2023
19 of 20 checks passed
etaques added a commit that referenced this pull request Oct 10, 2023
* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP

* feat(maestro): WIP, still missing monitor piece.

* feat(sinker): WIP.

* feat(sinker): WIP.

* feat(sinker): adding test cases to sinker new flow.

* feat(sinker): adding test cases to sinker new flow.

* feat(sinker): adding test cases to sinker new flow.

* feat(sinker): wiring new services.

* feat(sinker): clean up.

* feat(sinker): fix and clean up.

* feat(sinker): fix and clean up.

* feat(sinker): fix and clean up.

* feat(sinks): sinks new flow.

* feat(sinks): WIP

* fix(orb-ui): V1 Policy View new layout (#2646)

* feat(sinks): WIP

* feat(sinks): WIP

* feat(sinker): removed sinker non-otel pieces.

* feat(sinker): cleaning and fixes on sinker.

* feat(sinker): cleaning and fixes on sinker.

* improvement(orb-ui): #1191 Delete Selected Modal (#2649)

* improvement(orb-ui): #1191 Delete Selected Modal

* policy duplicate style

* feat(maestro): cleaning and fixes.

* feat(maestro): cleaning and fixes.

* feat(sinks): cleaning and fixes.

* feat(sinker): cleaning and fixes.

* feat(sinker): cleaning and fixes.

* feat(maestro): cleaning and fixes.

* feat(maestro): cleaning and fixes.

* feat(maestro): cleaning and fixes.

* feat(maestro): cleaning and fixes.

* fix(maestro): increase log tail on otel-collectors.

* fix(orb-ui): Sink details partial edit (#2658)

* feat(orb-ui): #26 Policy View Tabs (#2657)

* feat(orb-ui): #26 Policy View Tabs

* fix: datset table

* Remove comments and unnused imports

* New develop version 0.28.0 (#2656)

New develop version 0.28.0 (#2656)

* feat(maestro): adding the subtle pg import. (#2659)

Co-authored-by: Luiz Pegoraro <[email protected]>

* fix migrate query

* adding uuid as ID to follow the standard

* feat(maestro): add observability and logs to new flow on maestro.

* feat(orb-ui): #1267 Agent View Tabs (#2661)

* feat(maestro): adding more logs and removing return which could be omitting logs.

* feat(maestro): adding more logs and removing return which could be omitting logs.

* feat(logs): fixing logs and changing size source in otlp receiver.

* feat(logs): add more logs to check for errors.

* fix: (maestro) reference for redis streams

* feat(maestro): enhanced readability of sinker activity listener code.

* fix(sinks-maestro): fix encode and decode message.

* fix(maestro): fix config as byte for postgres support.

* fix(maestro): fix config as byte for postgres support.

* feat(logs): adding logs and unit tests.

* fix(orb-ui): Minor Adjustments on tabs components (#2665)

* feat(logs): adding logs and unit tests.

* feat(maestro): fixing and adding new tests.

* adding backend field on migrate db (#2668)

* fix (maestro): ommiting id once that is default random uuid (#2669)

* fix (maestro): lastInsertId not necessary (#2670)

Co-authored-by: etaques <[email protected]>

* fix(maestro): adding test cases and fixes logic for handling events (#2667)

* feat(maestro): fix update event and add redundancy to update when there isnt a deployment in db.

* feat(maestro): add unit test for delete

* feat(maestro): add unit test for delete

* feat(maestro): fix delete flow.

* feat(maestro): fixes sink activity.

* feat(maestro): fixes not encoding

* feat(maestro): fixes create flow.

* feat(maestro): fix on handle activity.

* fix (ci): required step to publish on stg

* fix(maestro): fixes sink idle event (#2672)

* feat(maestro): fix update event and add redundancy to update when there isnt a deployment in db.

* feat(maestro): add unit test for delete

* feat(maestro): add unit test for delete

* feat(maestro): fix delete flow.

* feat(maestro): fixes sink activity.

* feat(maestro): fixes not encoding

* feat(maestro): fixes create flow.

* feat(maestro): fix on handle activity.

* feat(maestro): fix on handle idle.

* feat(maestro): fix on handle idle.

* feat(maestro): unique sink ids for not racing.

* feat(maestro): fix failing test.

* fix(orb-ui): fit height tabs components (#2674)

* fix(maestro): fix unit tests and flows. (#2673)

* feat(maestro): fix update event and add redundancy to update when there isnt a deployment in db.

* feat(maestro): add unit test for delete

* feat(maestro): add unit test for delete

* feat(maestro): fix delete flow.

* feat(maestro): fixes sink activity.

* feat(maestro): fixes not encoding

* feat(maestro): fixes create flow.

* feat(maestro): fix on handle activity.

* feat(maestro): fix on handle idle.

* feat(maestro): fix on handle idle.

* feat(maestro): unique sink ids for not racing.

* feat(maestro): fix failing test.

* feat(maestro): fix failing test.

* feat(maestro): fix failing test.

* feat(maestro): skipping data race test.

* feat(maestro): skipping data race test.

* fix(maestro): fix maestro

* fix(maestro): fix SQL.

* fix(maestro): fix SQL.

* fix(maestro): fix SQL.

* fix(maestro): fix sqls (#2675)

* fix(maestro): fix maestro

* fix(maestro): fix SQL.

* fix(maestro): fix SQL.

* fix(maestro): fix SQL.

---------

Co-authored-by: Luiz Pegoraro <[email protected]>

* fix(maestro): change how read sinker events.

* fix(orb-ui): User able to create and edit yaml policies using json … (#2676)

* fix(orb-ui): User able to create and edit yaml policies using json | Include upload file policy view

* fix translation

* fix(maestro): fix event reading.

* feat(maestro): fix reading event and add logs to errors. (#2678)

feat(maestro): fix reading event and add logs to errors. (#2678)

* feat(maestro): fix args sent to find.

* feat(maestro): add repository tests and fixed errors on repository.

* fix (maestro): upgrade kubectl to k8s 1.27.4

* feat(maestro): fix get deployment and add logs to sink_activity. (#2690)

* feat(maestro): fix get deployment and add logs to sink_activity.

* feat(maestro): fix update deployment.

* feat(maestro): remove redundancy.

* feat(maestro): fix typo.

* feat(maestro): add debug logs to sinker listeners. (#2691)

* fix(maestro): fix decode event (#2692)

* feat(maestro): add debug logs to sinker listeners.

* feat(maestro): fix decode event.

* feat(maestro): add logs to understand better the fixes.

* feat(maestro): add logs to understand better the fixes.

* feat(maestro): fix decrypt. (#2694)

* fix(maestro): injection on monitor was missing (#2695)

* feat(maestro): fix decrypt.

* feat(maestro): fix monitor injection.

* feat(maestro): remove debug

* feat(maestro): fix storing decoded auths. (#2696)

* fix (sinks): maestro status event source subscribe

* fix (maestro): event source topic name

* set sink status when deployment status change

* feat(maestro): fix doubling update. (#2699)

* set sink status when deployment status change (#2700)

Co-authored-by: etaques <[email protected]>

* fix(orb-ui): #1281 Accordions and Tabs closing after refresh (#2701)

* fix(maestro): logs filtering to make it more clear the error (#2702)

* feat(logs): reduced a few messages of duration to debug level on other microservices.

* feat(maestro): remove debug logs

* feat(maestro): add log to compare collector name and deployment name

* fix (maestro) collectorName should be deployment name (#2703)

* set sink status when deployment status change

* fix (maestro) collectorName should be deployment name

---------

Co-authored-by: etaques <[email protected]>

* feat(sinks): add log on receiveing message from maestro.

* feat(sinks): add log on receiveing message from maestro. (#2704)

* feat(sinks): add log on receiveing message from maestro.

* fix: (maestro) monitor to kill orphaned otelcollectors

* fix: (sinks) update state

* fix: (maestro) monitor to kill orphaned otelcollectors (#2705)

* set sink status when deployment status change

* fix: (maestro) monitor to kill orphaned otelcollectors

* fix: (sinks) update state

---------

Co-authored-by: etaques <[email protected]>

* feat(sinker): add debounce of 1 min per sinker to not publish every metric on redis sink_activity.

* fix(orb-ui): improvements on view headers (#2706)

* fix: (sinks) update state

* add changes

* add changes

* refactor: update readme and fix linting errors (#2708)

* updated README
* fix missing imports and @include
* updated tslint.json: remove deprecated/reduntant rules
* update lint:fix
* fix scss linting
* add task for fixing scss lint

* fix(maestro): fix re-uping errored container without update. (#2710)

Co-authored-by: Luiz Pegoraro <[email protected]>

* add changes

* add changes

* add changes

* add changes

* add changes

* add changes

* fix(sinks): add new changes to postgres. (#2711)

* fix(maestro): fix re-uping errored container without update.

* fix(maestro): fix re-uping errored container without update.

---------

Co-authored-by: Luiz Pegoraro <[email protected]>

* feat(maestro): update error message not showing and on update sink not rolling back to unknown.

* feat(maestro): fix not deploying based on last status.

* feat(maestro): fix update deployment.

* feat(maestro): fix update deployment.

* feat(maestro): fix update deployment.

* fix (maestro): reset error message when sink update (#2717)

Co-authored-by: etaques <[email protected]>

* feat(maestro): add rules to activity, so sink does not switch from active to provisioning everytime.

* feat(maestro): change base status to unknown.

* feat(maestro): change base status to unknown.

* hotfix: update UI dockerfiles (#2713)

* update node to v14.21.3 (lts/fermium)

* replace yarn with npm

* fix (kind): update kind and kubectl to 1.27 (#2719)

* update kind and kubectl to 1.27

* Update values.yaml

* fix (maestro): activity and error event synchronization (#2720)

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

* trying to fix events

---------

Co-authored-by: etaques <[email protected]>

* fix: (sinker): idle state based on redis pubsub keystore events

* improvements(orb-ui): Dataset Windows (#2721)

* improvements(orb-ui): Dataset Windows

* console.log

* fix: (sinker): idle state based on redis pubsub keystore events

* Update sink_key_expire.go

* Update sinker_idle.go

* Update sinker_idle.go

* Update sinker_test.go

* Update sinker_test.go

* Update Chart.yaml

* fix (kind): [ENG-1279] psp on kind (#2724)

* fix (kind): disable psp on kind

* Update values.yaml

* Update Makefile

* fix (kind): chart version to 1.0.52 (#2725)

* fix(orb-ui) #1303 Code editors expose syntax errors (#2726)

* fix(orb-ui) #1303 Code editors expose syntax errors

* lint fix

* fix lint 2

* fix(orb-ui): Validate agent metadata before searching for agent version (#2727)

* fix: (sinker) idle expire message (#2729)

* fix: (sinker) idle message

* fix: (sinker) idle message

* fix: (sinker) idle message

* fix: (sinker) idle message

* Update Chart.yaml

* fix: (sinker) idle message

* fix: (sinker) idle message

---------

Co-authored-by: etaques <[email protected]>

* fix (maestro): returning sink from idle to active (#2730)

* fix: (sinker) idle message

* fix: (sinker) idle message

* fix: (sinker) idle message

* fix: (sinker) idle message

* Update Chart.yaml

* fix: (sinker) idle message

* fix: (sinker) idle message

* fix (maestro) returning from idle to active

---------

Co-authored-by: etaques <[email protected]>

* feat(kind): adding local development tools (#2731)

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

* feat(kind): adding local development tools

---------

Co-authored-by: etaques <[email protected]>

* fix(orb-ui): edit policy validate json config (#2728)

* feat(ui): add color to new status (#2734)

* feat(ui): add colour to new statuses.

* add colors on delete selected modal

---------

Co-authored-by: Luiz Pegoraro <[email protected]>

* feat(orb-ui): Expose warning sink messages (#2735)

* feat(orb-ui): Expose warning sink messages

* remove sink details scss

* fix(orb-ui): Sink state circle colors (#2736)

* fix(orb-ui): Sink state circle colors

* fix background

* fix(orb-ui): Active policies formatting (#2737)

* feat(maestro): add redundancy to create deployment when receives activity without deployment in the database.

* feat(maestro): fix unit test

* feat(maestro): fix unit test

* feat(maestro): fix unit test

* fix (maestro): create db, add unique constraint (#2742)

* fix (maestro) db and typo on activity variable (#2743)

* Update init.go

* fix maestro

* Update init.go

* Update deploy_service.go

* Update repository_test.go

---------

Co-authored-by: Luiz Pegoraro <[email protected]>
Co-authored-by: joaoguilherme2003 <[email protected]>
Co-authored-by: Luiz Pegoraro <[email protected]>
Co-authored-by: Luiz Henrique Pegoraro <[email protected]>
Co-authored-by: etaques <[email protected]>
Co-authored-by: Guilhermo Pazuch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants