Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (sinks): set sink status when deployment status change #2709

Merged
merged 16 commits into from
Oct 4, 2023

Conversation

etaques
Copy link
Contributor

@etaques etaques commented Oct 3, 2023

No description provided.

@github-actions github-actions bot added the golang label Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #2709 (6b05013) into develop (0d90cb7) will increase coverage by 6.57%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2709      +/-   ##
===========================================
+ Coverage    51.31%   57.89%   +6.57%     
===========================================
  Files           79       70       -9     
  Lines         5940     5239     -701     
===========================================
- Hits          3048     3033      -15     
+ Misses        2892     2206     -686     
Files Coverage Δ
sinks/sinks.go 18.75% <ø> (ø)
sinks/api/http/metrics.go 0.00% <0.00%> (ø)
sinks/api/http/logging.go 0.00% <0.00%> (ø)
sinks/sinks_service.go 56.12% <0.00%> (-4.10%) ⬇️

... and 9 files with indirect coverage changes

@etaques etaques requested review from lpegoraro and removed request for lpegoraro October 4, 2023 00:04
@etaques etaques requested a review from lpegoraro October 4, 2023 00:47
@lpegoraro lpegoraro merged commit eb7058c into develop Oct 4, 2023
20 checks passed
@lpegoraro lpegoraro deleted the etaques-patch-12 branch October 4, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants