Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maestro): update error message not showing and on update sink no… #2712

Merged

Conversation

lpegoraro
Copy link
Contributor

…t rolling back to unknown.

@lpegoraro lpegoraro requested a review from etaques October 4, 2023 13:16
@lpegoraro lpegoraro self-assigned this Oct 4, 2023
@github-actions github-actions bot added the golang label Oct 4, 2023
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #2712 (5bdcdb6) into develop (eb7058c) will increase coverage by 6.81%.
Report is 1 commits behind head on develop.
The diff coverage is 20.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2712      +/-   ##
===========================================
+ Coverage    51.31%   58.12%   +6.81%     
===========================================
  Files           79       70       -9     
  Lines         5940     5213     -727     
===========================================
- Hits          3048     3030      -18     
+ Misses        2892     2183     -709     
Files Coverage Δ
sinks/postgres/init.go 80.00% <ø> (ø)
sinks/sinks_service.go 59.77% <100.00%> (-0.45%) ⬇️
maestro/deployment/service.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@lpegoraro lpegoraro merged commit b501449 into orb-community:develop Oct 4, 2023
20 checks passed
@lpegoraro lpegoraro deleted the fix-1118-fix-sinks-update branch January 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants