Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(maestro): fix deployment skipping on last status was error #2715

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix(maestro): fix deployment skipping on last status was error #2715

merged 3 commits into from
Oct 4, 2023

Conversation

lpegoraro
Copy link
Contributor

No description provided.

@lpegoraro lpegoraro requested a review from etaques October 4, 2023 14:05
@lpegoraro lpegoraro self-assigned this Oct 4, 2023
@github-actions github-actions bot added the golang label Oct 4, 2023
@lpegoraro lpegoraro changed the title Fix activity skip error fix(maestro): fix deployment skipping on last status was error Oct 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2715 (75eb241) into develop (eb7058c) will increase coverage by 6.88%.
Report is 3 commits behind head on develop.
The diff coverage is 9.09%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2715      +/-   ##
===========================================
+ Coverage    51.31%   58.20%   +6.88%     
===========================================
  Files           79       70       -9     
  Lines         5940     5206     -734     
===========================================
- Hits          3048     3030      -18     
+ Misses        2892     2176     -716
Files Coverage Δ
sinks/postgres/init.go 80.00% <ø> (ø)
sinks/sinks_service.go 59.77% <100.00%> (-0.45%) ⬇️
maestro/service/deploy_service.go 0.00% <0.00%> (ø)
maestro/deployment/service.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

etaques
etaques suggested changes Oct 4, 2023
View reviewed changes
maestro/service/deploy_service.go Outdated Show resolved Hide resolved
@lpegoraro lpegoraro requested a review from etaques October 4, 2023 14:24
etaques
etaques approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpegoraro lpegoraro merged commit aa673ac into orb-community:develop Oct 4, 2023
20 checks passed
@lpegoraro lpegoraro deleted the fix_activity_skip_error branch January 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etaques etaques etaques approved these changes

Assignees

@lpegoraro lpegoraro

Labels
golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpegoraro @codecov-commenter @etaques