Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (maestro): reset error message when sink update #2717

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix (maestro): reset error message when sink update #2717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions maestro/deployment/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ package deployment

import (
"encoding/json"
"github.com/orb-community/orb/pkg/types"
"time"

"github.com/orb-community/orb/pkg/types"
)

type Deployment struct {
Expand Down Expand Up @@ -40,7 +41,7 @@ func (d *Deployment) Merge(other Deployment) error {
if other.Id != "" {
d.Id = other.Id
}
if other.LastErrorMessage != "" {
if other.LastErrorMessage != d.LastErrorMessage {
d.LastErrorMessage = other.LastErrorMessage
d.LastErrorTime = other.LastErrorTime
}
Expand All @@ -49,7 +50,7 @@ func (d *Deployment) Merge(other Deployment) error {
d.LastCollectorDeployTime = other.LastCollectorDeployTime
d.LastCollectorStopTime = other.LastCollectorStopTime
}
if other.LastStatus != "" {
if other.LastStatus != d.LastStatus {
d.LastStatus = other.LastStatus
d.LastStatusUpdate = other.LastStatusUpdate
}
Expand Down
Loading