-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng-512 oteltests #2821
Eng-512 oteltests #2821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And the container logs should contain the message "completed RPC subscription to group" within 30 seconds | ||
And this agent's heartbeat shows that 1 policies are applied and all has status running | ||
And the container logs contain the message "policy applied successfully" referred to each policy within 30 seconds | ||
# And the container logs that were output after all policies have been applied contain the message "scraped and published telemetry" referred to each applied policy within 180 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason behind this step being commented out here and in the next scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason is that log wasn't implemented yet when I wrote these scenarios and I'm not sure if they are accurate to http check, but would like to highlight that they exist for pktvisor. Do you or pegoraro already know how is the current state of this? I will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, scraped and published telemetry
log for otel
backend should be present already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manrodrigues @mfiedorowicz, a thought.
We currently have 2 log entries, which do you think is best for asserting that metrics were scraped successfully?
{"level":"info","ts":"2023-12-01T13:47:08.558Z","caller":"otlpmqttexporter/otlp.go:171","msg":"scraped metrics for policy","policy":"github_check","policy_id":"cc7b31a2-8e57-4f1c-9504-7ef98b9f660b"}
{"level":"info","ts":"2023-12-01T13:47:08.662Z","caller":"otlpmqttexporter/otlp.go:171","msg":"scraped metrics for policy","policy":"otel_orb_std","policy_id":"8f425ce7-2ac9-4f99-b3bd-7e2c1fafd389"}
{"level":"info","ts":"2023-12-01T13:47:08.674Z","caller":"otlpmqttexporter/otlp.go:171","msg":"scraped metrics for policy","policy":"new_std","policy_id":"034d9745-d96a-42fc-904f-3fff74c5cc09"}
{"level":"info","ts":"2023-12-01T13:47:08.790Z","caller":"otlpmqttexporter/otlp.go:305","msg":"scraped and published telemetry","topic":"channels/98b27953-0404-4507-b430-11467cea2188/messages/otlp/otel/m/e","payload_size_b":1411,"compressed_payload_size_b":408}
{"level":"info","ts":"2023-12-01T13:47:08.908Z","caller":"otlpmqttexporter/otlp.go:305","msg":"scraped and published telemetry","topic":"channels/98b27953-0404-4507-b430-11467cea2188/messages/otlp/otel/m/e","payload_size_b":2470,"compressed_payload_size_b":467}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to have scraped and published telemetry
by policy, to be compatible with pktvisor
on that note, what would be the reason to have scraped metric
and then scraped telemetry
. how are they different?
tests are added with tag @smoke_otel_backend
set not default variables in test_config.ini:
Tests behavior need to be modified according to expected results in the future