feat(agent): remove option to set otel to false in orb agent #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2839 +/- ##
===========================================
- Coverage 48.53% 3.14% -45.39%
===========================================
Files 85 15 -70
Lines 6330 1080 -5250
===========================================
- Hits 3072 34 -3038
+ Misses 3258 1046 -2212 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Do we need to keep Opentelemetry.Enable in https://github.com/orb-community/orb/blob/develop/agent/config/types.go#L39?
lpegoraro
deleted the
eng-1631-remove-option-to-set-otel-to-false-in-orb-agent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.