-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sinks): enable sinks with token auth. #3061
Conversation
Hey @pburrows-ns1, thanks for the first-time contribution/pull request 👏🏻 We'll do our best to review it in a timely manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pburrows-ns1! Apart from a few minor or code style comments and one clarifying question, it looks like a great contribution 👏🏻
@pburrows-ns1 could you also merge develop into your branch which has a fix for one of GHA workflows failing here (plus one conflict requiring resolving)? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pburrows-ns1, thanks for contribution!
Enable sinks to be configured with token based authentication.
The required fields for this auth type are:
scheme
token
Rather than
scheme
being fixed toBearer
, it's customizable because there are many schemes it could be.For example Dynatrace expect the header to be:
Authorization: Api-Token dt0c01.abc123.abcdefjhij1234567890
With the following authentication settings configured on a sink:
The resulting yaml configuration is:
This is in line with what's expected:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/4115aad52e0775caed38c3ccc450d8064044efaa/extension/bearertokenauthextension