Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): remove unused gorelease config #5

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

corybekk
Copy link
Collaborator

@corybekk corybekk commented Jan 13, 2025

Description

The aws-nuke binaries were not being created due to several failing GitHub workflows. To address this, I made the following changes:

  1. Removed post-hooks, signing, and image deployment steps from the GitHub GoReleaser action:
    • Post-hooks and signing steps were removed because they relied on missing Quill keys, which are not used in our setup.
    • Image deployment was removed due to permission issues, as this functionality is also not used.

Shoutout to @danarbaugh for going through the github workflows with me. It was ultimately decided to keep the semantic commit convention on this fork to ensure our upstream PR's are accepted without issue.

@corybekk corybekk changed the title edit github actions fix(goreleaser): remove unused config Jan 13, 2025
@corybekk corybekk changed the title fix(goreleaser): remove unused config fix(goreleaser): remove unused gorelease config Jan 13, 2025
@corybekk corybekk marked this pull request as ready for review January 13, 2025 23:04
Copy link
Member

@danarbaugh danarbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to correctly correspond with your PR description to me. Thanks Cory!

@corybekk corybekk merged commit baf50d8 into oreilly-main Jan 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants