cl-724 Adding support for codedeploy deployment configs and codepipeline custom action types and webhooks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to errors with using the cloud control resource type AWS::CodeDeploy::DeploymentConfig, creating custom nuke module for CodeDeploy Deployment Configs.
gsoria
reviewed
Nov 1, 2023
Co-authored-by: Gabriela Soria <[email protected]>
swhite-oreilly
changed the title
Adding needed provider and version.
swhite-oreilly
changed the title
gsoria
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
This looks good to me, confirmed locally that accounts are cleanup up correctly:
us-east-1 - CodeDeployDeploymentGroup - CodeDeployDemo_DG - [ApplicationName: "CodeDeployDemoApplication-20fdbddbb85b101b5943", DeploymentGroupName: "CodeDeployDemo_DG"] - removed
us-east-1 - CodeDeployDeploymentConfig - ThreeQuartersHealthy - [DeploymentConfigName: "ThreeQuartersHealthy"] - removed
corybekk
pushed a commit
that referenced
this pull request
Nov 6, 2024
* chore: update to actions/checkout@v4 * chore: update to actions/configure-pages@v4 * chore: update to actions/deploy-pages@v4 * chore: actions/setup-go@v5 * chore: update to actions/upload-artifact@v4 * chore: actions/setup-python@v5 * chore: actions/upload-pages-artifact@v3 * chore: update to docker/login-action@v3 * chore: update docker actions * update goreleaser-action to v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deployment config support for CodeDeploy deployment configs and groups along with CodePipeline custom action types and webhooks.
Tests scripts are included in the related PR
Note: Due to errors with using the cloud control resource types AWS::CodeDeploy::DeploymentConfig and AWS::CodePipeline::CustomActionType, creating this custom nuke modules for these resource types.