Fix deletion of backup vault access policies that contain restrictive policy #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses to prevent their deletion This commit fixes the following error when trying to delete backup vault access policies for vaults (`aws/efs/automatic-backup-vault`) automatically created when EFS backup is enabled. ``` time="2023-10-05T15:37:07Z" level=error msg="AccessDeniedException: User: arn:aws:sts::X:assumed-role/XRole/SAAssumedRoleSession is not authorized to perform: backup:DeleteBackupVaultAccessPolicy on resource: arn:aws:backup:us-east-1:X:backup-vault:aws/efs/automatic-backup-vault with an explicit deny in a resource-based policy ``` The module before attempting to delete the backup vault access policy, sets a permissive policy to ensure the `backup:DeleteBackupVaultAccessPolicy` is allowed. The operation to put a policy to allow `backup:DeleteBackupVaultAccessPolicy` was silently failing due to an error: ``` The specified policy cannot be added to the vault due to cross-account sharing restrictions. Amend the policy or the vault's settings, then retry request ``` This commit updates the policy, to use the default as a template, but excluding delete actions. Signed-off-by: Gabriela S. Soria <[email protected]>
danarbaugh
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
I followed the testing steps to confirm I received the expected AccessDeniedException error on the account with a version built from main then a subsequent run with the same configuration using a build from this branch resulted in
us-east-1 - AWSBackupVaultAccessPolicy - aws/efs/automatic-backup-vault - removed as expected. Thanks Gaby. This is a great bugfix that I am sure will be appreciated upstream! 👏
corybekk
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Everything worked for me! thank you for including the commands for creating the resources.
Testing output
Do you really want to nuke these resources on the account with the ID 299719426765 and the alias 'alias-299719426765'?
Waiting 3s before continuing.
us-east-1 - AWSBackupVaultAccessPolicy - aws/efs/automatic-backup-vault - triggered remove
Removal requested: 1 waiting, 0 failed, 1 skipped, 0 finished
us-east-1 - AWSBackupVaultAccessPolicy - aws/efs/automatic-backup-vault - waiting
Removal requested: 1 waiting, 0 failed, 1 skipped, 0 finished
us-east-1 - AWSBackupVaultAccessPolicy - aws/efs/automatic-backup-vault - removed
Removal requested: 0 waiting, 0 failed, 1 skipped, 1 finished
Nuke complete: 0 failed, 1 skipped, 1 finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following error when trying to delete backup vault access policies for vaults (
aws/efs/automatic-backup-vault) automatically created when EFS backup is enabled.The module before attempting to delete the backup vault access policy, sets a permissive policy to ensure the
backup:DeleteBackupVaultAccessPolicyis allowed.The operation to put a policy to allow
backup:DeleteBackupVaultAccessPolicywas silently failing due to an error:This commit updates the policy, to use the default as a template, but excluding delete actions.
Testing
Cleanup the account, specifying the resource
AWSBackupVaultAccessPolicy.You should see an output similar to this: